From 7f9662edab1c7d25c3a74506e365684e0befb7c3 Mon Sep 17 00:00:00 2001 From: Hakim El Hattab Date: Fri, 20 Jul 2012 22:09:56 -0400 Subject: [PATCH] null check progress DOM element even if it's configured to be on --- README.md | 1 + js/reveal.js | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index acc41477..298c1cfd 100644 --- a/README.md +++ b/README.md @@ -176,6 +176,7 @@ You can change the appearance of the speaker notes by editing the file at `plugi - Added beige theme - Added 'autoSlide' config - Bug fix: The 'slidechanged' event is now firing upon 'hashchange'. Thanks [basecode](https://github.com/basecode) +- Bug fix: JS error when the 'progress' option was true but there was no progress DOM element #### 1.3 - Revised keyboard shortcuts, including ESC for overview, N for next, P for previous. Thanks [mahemoff](https://github.com/mahemoff) diff --git a/js/reveal.js b/js/reveal.js index c9e69a8f..e0be8390 100644 --- a/js/reveal.js +++ b/js/reveal.js @@ -155,7 +155,7 @@ var Reveal = (function(){ dom.controls.style.display = 'block'; } - if( config.progress ) { + if( config.progress && dom.progress ) { dom.progress.style.display = 'block'; } @@ -680,7 +680,7 @@ var Reveal = (function(){ } // Update progress if enabled - if( config.progress ) { + if( config.progress && dom.progress ) { dom.progressbar.style.width = ( indexh / ( document.querySelectorAll( HORIZONTAL_SLIDES_SELECTOR ).length - 1 ) ) * window.innerWidth + 'px'; }