phyks/libbmc
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix ISBN validation and complete unittests

Browse Source
This commit is contained in:
Lucas Verney 2016-01-24 18:21:52 +01:00
parent eb576f5fa6
commit bed4ffff69
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libbmc/isbn.py
View File

@ -37,7 +37,11 @@ def is_valid(isbn):
>>> is_valid("123456789X") >>> is_valid("123456789X")
True True
""" """
return not isbnlib.notisbn(isbn) return (
(not isbnlib.notisbn(isbn)) and (
isbnlib.get_canonical_isbn(isbn) == isbn or
isbnlib.mask(isbnlib.get_canonical_isbn(isbn)) == isbn)
)
def extract_from_text(text): def extract_from_text(text):

3
libbmc/tools.py
View File

@ -82,7 +82,8 @@ def batch(iterable, size):
:params size: Size of the batches. :params size: Size of the batches.
:returns: A new batch of the given size at each time. :returns: A new batch of the given size at each time.
# TODO: Unittest >>> [list(i) for i in batch([1, 2, 3, 4, 5], 2)]
[[1, 2], [3, 4], [5]]
""" """
it = iter(iterable) it = iter(iterable)
while True: while True: