diff --git a/.eslintrc.js b/.eslintrc.js index 635bdee..e23ca95 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -43,6 +43,9 @@ module.exports = { "error", ], "react/jsx-uses-react": "error", - "react/jsx-uses-vars": "error" + "react/jsx-uses-vars": "error", + + // Disable no-console rule in production + "no-console": process.env.NODE_ENV !== "production" ? "off" : ["error"] } }; diff --git a/TODO b/TODO index f9dd7f4..794d209 100644 --- a/TODO +++ b/TODO @@ -11,6 +11,14 @@ * /artist/:id and /album/:id arts in responsive view * Scroll horizontal sidebar * Move CSS in modules + => https://github.com/gajus/react-css-modules + +# API middleware + * https://github.com/reactjs/redux/issues/1824#issuecomment-228609501 + * https://medium.com/@adamrackis/querying-a-redux-store-37db8c7f3b0f#.eezt3dano + * https://github.com/reactjs/redux/issues/644 + * https://github.com/peterpme/redux-crud-api-middleware/blob/master/README.md + * https://github.com/madou/armory-front/tree/master/src/app/reducers ## Global UI @@ -20,9 +28,5 @@ ## Miscellaneous * See TODOs in the code - * https://facebook.github.io/immutable-js/ ? - * Web workers? - * Accessibility and semantics - * Uncaught TypeError: this.props.tracks.forEach is not a function - => Be more robust, after, getHostNode is null + => Be more robust, else, getHostNode is null after diff --git a/app/components/Login.jsx b/app/components/Login.jsx index 72713de..1fa9b4e 100644 --- a/app/components/Login.jsx +++ b/app/components/Login.jsx @@ -50,7 +50,9 @@ export class LoginForm extends Component { this.props.error ?
+ { this.props.error } +
{ this.props.info }