Don't break when moving outside of playlist bounds with next / previous buttons
This commit is contained in:
parent
7c1d7dacc3
commit
4f8f201e67
@ -124,20 +124,25 @@ export default createReducer(initialState, {
|
||||
[PLAY_PREVIOUS_SONG]: (state) => {
|
||||
const newIndex = state.get("currentIndex") - 1;
|
||||
if (newIndex < 0) {
|
||||
// If there is an overlow on the left of the playlist, just stop
|
||||
// playback
|
||||
// TODO: Behavior is not correct
|
||||
return stopPlayback(state);
|
||||
// If there is an overlow on the left of the playlist, just play
|
||||
// first music again
|
||||
// TODO: Should seek to beginning of music
|
||||
return state;
|
||||
} else {
|
||||
return state.set("currentIndex", newIndex);
|
||||
}
|
||||
},
|
||||
[PLAY_NEXT_SONG]: (state) => {
|
||||
const newIndex = state.get("currentIndex") + 1;
|
||||
if (newIndex > state.get("playlist").size) {
|
||||
// If there is an overflow, just stop playback
|
||||
// TODO: Behavior is not correct
|
||||
return stopPlayback(state);
|
||||
if (newIndex >= state.get("playlist").size) {
|
||||
// If there is an overflow
|
||||
if (state.get("isRepeat")) {
|
||||
// TODO: Handle repeat
|
||||
return state;
|
||||
} else {
|
||||
// Just stop playback
|
||||
return state.set("isPlaying", false);
|
||||
}
|
||||
} else {
|
||||
// Else, play next item
|
||||
return state.set("currentIndex", newIndex);
|
||||
|
@ -75,7 +75,6 @@ class WebPlayer extends Component {
|
||||
startPlaying(props) {
|
||||
if (props.isPlaying && props.currentSong) {
|
||||
// If it should be playing any song
|
||||
if (!this.howl) {
|
||||
// Build a new Howler object with current song to play
|
||||
const url = props.currentSong.get("url");
|
||||
this.howl = new Howl({
|
||||
@ -86,10 +85,6 @@ class WebPlayer extends Component {
|
||||
autoplay: false, // No autoplay, we handle it manually
|
||||
onend: () => props.actions.playNextSong(), // Play next song at the end
|
||||
});
|
||||
} else {
|
||||
// Else, something is playing
|
||||
// TODO If it is not the expected song, change it
|
||||
}
|
||||
// Start playing
|
||||
this.howl.play();
|
||||
}
|
||||
|
File diff suppressed because one or more lines are too long
File diff suppressed because one or more lines are too long
File diff suppressed because one or more lines are too long
Loading…
Reference in New Issue
Block a user